Re: [PATCH] status: be prepared for not-yet-started interactive rebase

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 22, 2016, 19:02 UTC
Message-ID: <alpine.DEB.2.20.1601222000040.2964@virtualbox>
In-Reply-To: <xmqqio2lv4rg.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Fri, 22 Jan 2016, Junio C Hamano wrote:

Show 12 quoted lines

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> 
> > Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> >
> >>  wt-status.c | 22 +++++++++++++++-------
> >>  1 file changed, 15 insertions(+), 7 deletions(-)
> >
> > Looks good to me. You may want to add a test by overriding $EDITOR to a
> > script doing "git status >actual" if you want to have fun with testing.
> 
> I am unhappy that the code does not read 'rebase-todo' at all when
> 'done' is missing.

At this point is virtually certain that the edit script is opened in an editor, and very likely to change. So it makes little sense to look at the todo.

Ciao, Dscho