Re: [PATCH 0/4] Always release pack files before calling gc --auto

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 13, 2016, 18:52 UTC
Message-ID: <alpine.DEB.2.20.1601131951040.2964@virtualbox>
In-Reply-To: <20160113175237.GA13139@sigill.intra.peff.net>

Hi Peff,

On Wed, 13 Jan 2016, Jeff King wrote:

Show 19 quoted lines

> On Wed, Jan 13, 2016 at 06:20:02PM +0100, Johannes Schindelin wrote:
> 
> > These patches are companions to 786b150 (clone --dissociate: avoid
> > locking pack files, 2015-10-06), triggered by a bug report to the Git
> > for Windows project.
> > 
> > Johannes Schindelin (4):
> >   fetch: release pack files before garbage-collecting
> >   am: release pack files before garbage-collecting
> >   merge: release pack files before garbage-collecting
> >   receive-pack: release pack files before garbage-collecting
> 
> [...]
>
> I think all of the cases here are fine, for two reasons:
> 
>   1. The new closing is right before the program would exit anyway, so
>      there's no interesting work left to do (and obviously that's where
>      we generally want to call "gc --auto", too)

This is actually what I checked, but of course I managed to forget to mention it in the cover letter :-(

Thanks for verifying, and for spelling it out. Dscho