Re: Re: [PATCH] push: allow --follow-tags' to be set by config push.followTags

From: Dave Olszewski <cxreg@pobox.com>
Date: Feb 16, 2015, 03:01 UTC
Message-ID: <alpine.DEB.2.11.1502151859230.16979@narbuckle.genericorp.net>
In-Reply-To: <CAPc5daXkf3Vc-kGsqQ4zo6qSMrh93GZbXeFK9oLwajyNahmx1Q@mail.gmail.com>

On Sun, 15 Feb 2015, Junio C Hamano wrote:

Show 22 quoted lines

> On Sun, Feb 15, 2015 at 3:39 PM, Dave Olszewski <cxreg@pobox.com> wrote:
> > Signed-off-by: Dave Olszewski <cxreg@pobox.com>
> >
> > diff --git a/Documentation/config.txt b/Documentation/config.txt
> > index ae6791d..cdb8a99 100644
> > --- a/Documentation/config.txt
> > +++ b/Documentation/config.txt
> > @@ -2079,6 +2079,9 @@ new default).
> >
> >  --
> >
> > +push.followTags::
> > +       If set to true enable '--follow-tags' option by default.
> > +
> 
> After setting this in your repository, does "git push --no-follow-tags" let
> you override it if you want to do so for a single invocation?
> 
> If it does, the code is good but it should be documented here; if it
> does not, it should be corrected and it should be documented here.
> 
> Thanks.

Thanks for the feedback. I was able to get this behavior by setting the config value into the flags variable before parsing command line options. Hopefully this is acceptable practice. Updated patch coming shortly