Re: [PATCH 2/2] fsmonitor: Store fsmonitor bitmap before splitting index

From: Alex Vandiver <alexmv@dropbox.com>
Date: Dec 16, 2017, 02:02 UTC
Message-ID: <alpine.DEB.2.10.1712151800010.7105@alexmv-linux>
In-Reply-To: <9b6679ea-b7e4-b45a-32bb-448cd2e891df@gmail.com>

On Mon, 13 Nov 2017, Ben Peart wrote:

> Why do you redirect stdout to stderr and then and perform an "echo"
> afterwards?  I don't understand what benefit that provides.  I removed this
> logic and the test still passes so am confused as to what its purpose is.

Ah -- the "echo" was purely to clean up STDERR as I was running the test interactively. It serves no purpose, which is why it was hard to understand its benefit. :)

Apologies for missing this (and in not replying here earlier!).  I'll
send a commit that drops these.
 - Alex

Show 14 quoted lines

> > +# test that splitting the index dosn't interfere
> > +test_expect_success 'splitting the index results in the same state' '
> > +	write_integration_script &&
> > +	dirty_repo &&
> > +	git update-index --fsmonitor  &&
> > +	git ls-files -f >expect &&
> > +	test-dump-fsmonitor >&2 && echo &&
> > +	git update-index --fsmonitor --split-index &&
> > +	test-dump-fsmonitor >&2 && echo &&
> > +	git ls-files -f >actual &&
> > +	test_cmp expect actual
> > +'
> > +
> >   test_done