Re: [PATCH] git-sh-setup: Restore sourcability from outside scripts
- From
Anders Kaseorg <andersk@mit.edu>
- Date
- Oct 30, 2016, 19:21 UTC
- Message-ID
- <alpine.DEB.2.10.1610301503280.60842@buzzword-bingo.mit.edu>
- In-Reply-To
- <CACBZZX4SnJj6ZYK-Ha3EtiWUf_n=+LZ=UeS=7vxgsj8s=bi3Sg@mail.gmail.com>
On Sun, 30 Oct 2016, Ævar Arnfjörð Bjarmason wrote:
Show 7 quoted lines
> This seems like a reasonable fix for this issue. However as far as I > can tell git-sh-setup was never meant to be used by outside scripts > that didn't ship as part of git itself. > > If that's the case any change in the API which AFAICT is now > considered internal might break them, so should some part of that be > made public & documented as such?
It is documented (Documentation/git-sh-setup.txt), and this is not the internal Documentation/technical section of the documentation, so my default assumption would be that everything shown there is intended as public. I only bring this up as a question because it was apparently allowed to break. If I’m wrong and it isn’t public, other patches are needed (to the documentation and to its users in contrib).
Anders