git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-rebase skips automatically no more needed commits

From
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Date
Sep 16, 2011, 01:27 UTC
Message-ID
<alpine.DEB.2.00.1109151956040.12564@debian>
In-Reply-To
<7vwrdaqxpk.fsf@alter.siamese.dyndns.org>
Hi,
On Wed, 14 Sep 2011, Junio C Hamano wrote:
> What I said is "all 'am' need to use from its input while rebasing is the
> commit object name"; that is very different from "we have only commit
> object name so we must use cherry-pick" or "because we have commit object
> name, we can afford to use cherry-pick".
Right. I didn't mean to suggest that we should use cherry-pick.
> Look for $rebasing in git-am.sh and notice that:

Thanks! I had no idea about these "tricks" in git-am.sh. Now I understand much better what you meant. So we are currently getting the metainfo from the commit rather than from the mailbox. With your patch, we would also get the patch body from the commit. The only thing remaining after that is the commit log message, correct?

Once all that git-am reads from the mailbox while in $rebasing mode is the commit name, it would be as small change to teach it to read a list of commit names instead. Is this what you meant or did you really mean for format-patch to generate output without patch body? At this point the name 'am' becomes quite misleading, but maybe that's not worth worrying about.

Thanks, Martin

Previous: Junio C HamanoNext: Martin von Zweigbergk
Message 14 of 19 in “git-rebase skips automatically no more needed commits”
  1. Francis MoreauSep 6, 2011
  2. Junio C HamanoSep 6, 2011
  3. Francis MoreauSep 6, 2011
  4. Michael J GruberSep 7, 2011
  5. Junio C HamanoSep 7, 2011
  6. Francis MoreauSep 8, 2011
  7. Martin von ZweigbergkSep 8, 2011
  8. Martin von ZweigbergkSep 9, 2011
  9. Francis MoreauSep 9, 2011
  10. Martin von ZweigbergkSep 9, 2011
  11. Francis MoreauSep 9, 2011
  12. Martin von ZweigbergkSep 15, 2011
  13. Junio C HamanoSep 15, 2011
  14. Martin von ZweigbergkSep 16, 2011
  15. Martin von ZweigbergkSep 20, 2011
  16. Ramkumar RamachandraSep 24, 2011
  17. Martin von ZweigbergkSep 25, 2011
  18. Thomas RastSep 26, 2011
  19. Martin von ZweigbergkSep 28, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.