Re: [PATCH 1/2] Command names should not be translated.

From: Peter Krefting <peter@softwolves.pp.se>
Date: Sep 13, 2010, 05:07 UTC
Message-ID: <alpine.DEB.2.00.1009130706450.29710@perkele.intern.softwolves.pp.se>
In-Reply-To: <AANLkTinN_fDAVVuT1ygCe7gMpHqAhL4GGjrZ98igbbP3@mail.gmail.com>

Ævar Arnfjörð Bjarmason:

Show 8 quoted lines

> I disagree with all those. These don't end up being used in a context like:
>
>    die("git-%s: error ...", command);
>
> But:
>
>    die(_("Refusing to %s notes in %s (outside of refs/notes/)"),
>        _(subcommand), t->ref);

You are right. I saw the first as a duplicate source of the wt-status.c command name that I got for translation. Drop these, then.

Still the construct is a bit awkward, but possibly doable, at least for my language.

Show 6 quoted lines

> These however are good, because here it gets used as:
>
>    color_fprintf_ln(s->fp, c, _("#   (use \"git %s <file>...\" to
> include in what will be committed)"), how);
>
> I.e. this is purely a hardcoded command name.

Indeed.

-- 
\\// Peter - http://www.softwolves.pp.se/