Re: [PATCH 5/5] struct sockaddr_storage->ss_family is not portable
- From
Martin Storsjö <martin@martin.st>
- Date
- Apr 25, 2010, 19:05 UTC
- Message-ID
- <alpine.DEB.2.00.1004252204020.24585@cone.home.martin.st>
- In-Reply-To
- <20100312151522.GA11943@thor.il.thewrittenword.com>
Hi Gary,
On Sun, 25 Apr 2010, Gary V. Vaughan wrote:
Show 12 quoted lines
> On Fri, Mar 12, 2010 at 09:24:01AM +0200, Martin Storsj? wrote: > > > > Yes, but if the sockaddr struct can be arranged in different ways, the > > other ones (sockaddr_in, sockaddr_storage, sockaddr_in6) must also be > > defined coherently - you're always supposed to be able to cast an > > sockaddr_in (or any other of them) to a sockaddr and read the sa_family > > field. As far as I know, at least. > > Ah, good point. And now, having tested that on all our machines it > works perfectly, and is much more elegant! > > I'll resubmit presently.
Actually, Brandon Casey already submitted a patch doing this, which is available in master by now, so this issue is all taken care of. :-)
// Martin