Re: What's cooking in git.git (Dec 2009, #02; Sat, 05)

From: Martin Storsjö <martin@martin.st>
Date: Dec 6, 2009, 15:59 UTC
Message-ID: <alpine.DEB.2.00.0912061738580.5582@cone.home.martin.st>
In-Reply-To: <7vpr6siki5.fsf@alter.siamese.dyndns.org>

On Sun, 6 Dec 2009, Junio C Hamano wrote:

Show 9 quoted lines

> [Cooking]
> 
> * tr/http-updates (2009-12-01) 3 commits
>  - Allow curl to rewind the RPC read buffer
>  - Add an option for using any HTTP authentication scheme, not only basic
>  - http: maintain curl sessions
> 
> There was a discussion on a better structure not to require rewinding in
> the first place?  I didn't follow it closely...

I think the conclusion is: Rewinding support isn't strictly necessary, there's a number of mechanisms in both git and curl that should make sure that those cases shouldn't surface. A few of them in curl have an unfortunate conincidence of bugs up until the latest version, though, leaving much fewer mechanisms in place to avoid this.

Since that patch is quite non-intrusive I think it's a good safeguard, though. What do you think, Tay, keep it or leave it?

// Martin