Re: [PATCH v2] Add script for importing bits-and-pieces to Git.

From: Peter Krefting <peter@softwolves.pp.se>
Date: Aug 25, 2009, 18:59 UTC
Message-ID: <alpine.DEB.2.00.0908251953480.19406@ds9.cixit.se>
In-Reply-To: <7vy6p9do4k.fsf@alter.siamese.dyndns.org>

Junio C Hamano:

> Nice write-up.

Thank you.

As to your questions, they are very good, and I'll try to update the documentation a bit to clarify the points you made. This is the first time someone who is not myself have read it, so I expected some rough edges...

Follow-ups on some of the points (I will address the rest as well):

Show 5 quoted lines

> You might want to mention that this format is different from what git uses 
> for its .git/config and .gitmodules files, and none of the rules apply to 
> them (namely, two/three-level names, case sensitivity, allowed letters in 
> variable names, stripping of whitespaces around values, and value quoting) 
> described in 'git help config' apply to this file.

A quick question on that: Is it possible to use the git-config parser stand-alone from a script like this? Then that note wouldn't need to apply.

> As you seem to be supporting merges, you might want to say topologically 
> instead of chronologically---this is minor, as you give more precise 
> definition "all parents must come before a child" in that sentence later.

I'm not sure I get the distinction here. Could you be a bit more specific (or point me to what I have missed in the Git manual)?

> How are problematic characters in pathnames (say, SP, '=' or worse LF)
> handled?  Do they need to be quoted, and if so how?

In the current version: Not at all. :-) I didn't need to, at the time.

-- 
\\// Peter - http://www.softwolves.pp.se/