Re: [PATCH-v2/RFC 3/6] xutils: fix ignore-all-space on incomplete line

From: Thell Fowler <git@tbfowler.name>
Date: Aug 25, 2009, 05:58 UTC
Message-ID: <alpine.DEB.2.00.0908250018510.9656@GWPortableVCS>
In-Reply-To: <alpine.DEB.2.00.0908240910120.29625@GWPortableVCS>

Thell Fowler (git@tbfowler.name) wrote on Aug 24, 2009:

Show 18 quoted lines

> Junio C Hamano (gitster@pobox.com) wrote on Aug 24, 2009:
> 
> > Thell Fowler <git@tbfowler.name> writes:
> > 
> > > It passed every test I threw at it, although it seemed to be a tad bit 
> > > slower than the previous revision on my sample data so I ran the following 
> > > command several times for both the previous and current version:
> > >
> > 
> > Do you mean by "previous version" the one that was broken, or the one I
> > sent as a "how about" patch?
> > 
> 
> A quick test shows the version merged to pu is the one that had the 
> fastest times.  I'll be away from a connection most of today, but will 
> test the different versions against the tests and some sample data and 
> post back.
>

More extensive testing also shows the version currently in pu is the fastest on my sample data when applied to master. I'm not sure why pu shows slower times than those same commits applied to master, but they are close enough together that I'm guessing no-one would really be concerned.

I was sitting in a waiting room and decided to have a little fun figuring out how to average the sys times...

for arg in "" -w -b --ignore-space-at-eol;do sum=0 && for i in {1..50}; \ do n="$(/usr/bin/time -f "%S" -o /dev/stdout sh -c 'git diff $arg dirty_first>/dev/null;')"; \ sum=$sum+$n; done; echo "scale=2; ($sum)/$i"|echo "$(bc) avg for diff $arg"; done;

pu .28 avg for diff .29 avg for diff -w .33 avg for diff -b .29 avg for diff --ignore-space-at-eol

pu commits applied to master <=== FASTEST 9c0d402 xutils: Fix xdl_recmatch() on incomplete lines 21245fd xutils: Fix hashing an incomplete line with whitespaces at the end .26 avg for diff .25 avg for diff -w .29 avg for diff -b .31 avg for diff --ignore-space-at-eol

'how about' patch applied to master .26 avg for diff .32 avg for diff -w .29 avg for diff -b .32 avg for diff --ignore-space-at-eol

current master (in order to see the difference in the basic git diff -ignoring the fact that incomplete lines where broke since it only affects 2 files in the test data) .30 avg for diff .30 avg for diff -w .29 avg for diff -b .29 avg for diff --ignore-space-at-eol

-- Thell