Re: [PATCH] fix for incorrect index update

From: Dave Olszewski <cxreg@pobox.com>
Date: May 10, 2009, 04:46 UTC
Message-ID: <alpine.DEB.2.00.0905092139050.21000@narbuckle.genericorp.net>
In-Reply-To: <7vskjd4mfh.fsf@alter.siamese.dyndns.org>

On Sat, 9 May 2009, Junio C Hamano wrote:

Show 6 quoted lines

> Thanks.  I'd add:
>
> 	From: Dave Olszewski <cxreg@pobox.com>
>
> at the beginning, so you would not be shown as "Dave O" in "git shortlog"
> and friends.

Ok, sounds good. Thanks for the explanation of the issue. Much of the git internals are still mysterious but that's slowly changing :-)

> Much nicer than Dscho's ;-)

Well, it was mine first, can't fault him for that!

Show 8 quoted lines

> You inherited a bug from Dscho's patch, it seems.  Have you tried running
> the test with debug option?
>
> This could have been
>
> 	test_debug "echo create a bunch of files" &&
>
> but I'd say we just make them into comments.

I didn't, sorry for that.  Making them comments seems ok to me.

Thanks once again.

     Dave Olszewski