Re: Consecutive git gc fails on Windows network share
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 21, 2014, 16:57 UTC
- Message-ID
- <alpine.DEB.1.00.1401211755330.14982@s15462909.onlinehome-server.info>
- In-Reply-To
- <CABPQNSafcpACtWGBenE8vAe_XEvJ=5_sxLw8PztrnWp1xJAcjw@mail.gmail.com>
Hi kusma,
On Tue, 21 Jan 2014, Erik Faye-Lund wrote:
Show 21 quoted lines
> On Tue, Jan 21, 2014 at 12:25 AM, Johannes Schindelin > <Johannes.Schindelin@gmx.de> wrote: > > > > On Mon, 20 Jan 2014, Torsten Bögershausen wrote: > > > >> b) add "+++" at the places where you added the stat() and chmod(), > >> c) and to send the question "is this a good implementation ?" to upstream git. > >> > >> I think your implementation makes sense. > > > > As I said in my other reply, I think that the problem would be > > addressed more generally in compat/mingw.c. It is to be doubted highly > > that upstream wants to handle cases such as "rename() cannot overwrite > > read-only files on Windows" everywhere they call rename() because the > > platforms upstream cares about do not have that problem. > > I'm not so sure. A quick test shows me that this is not the case for > NTFS. Since this is over a network-share, the problem is probably > server-side, and can affect other systems as well. > > So a work-around might be appropriate for all systems, no?
I do not think that the problem occurs if you run the same commands on Linux, on a mounted Samba share. So I guess that upstream Git can enjoy their luxury of not having to care.
In any case, if we would need this also for Linux, doing it for only one user of rename() would probably not be good enough, either... so something similar to mingw_rename() would be needed (interfering with mingw_rename itself, of course).
Ciao, Dscho
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.