Re: [PATCH] Remove the line length limit for graft files
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 27, 2013, 22:51 UTC
- Message-ID
- <alpine.DEB.1.00.1312272347460.1191@s15462909.onlinehome-server.info>
- In-Reply-To
- <20131227215919.GF20443@google.com>
Hi Jonathan,
On Fri, 27 Dec 2013, Jonathan Nieder wrote:
Show 6 quoted lines
> Johannes Schindelin wrote: > > > it returns EOF only if ch == EOF *and* sb->len == 0, i.e. if no characters > > have been read before hitting EOF. > > Yep. api-strbuf.txt even says so.
I never bothered to look ;-)
> Sorry for the nonsense.
Nope, no nonsense at all. I actually had a look only after your review, and it definitely makes sense to double-check.
> For what it's worth, > Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
It is worth a lot. Believe me, I know just how thankless a task reviewing is, and instead of getting praise for it, you even get abused by contributors who would rather self-review their code for fear of having a twist in their knockers pointed out publicly.
Your review makes the code better, even if it does not result in code changes all the time: it increases the confidence that the code is good.
Thank you, Jonathan! Dscho
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.