Re: [PATCH] diff: remove another ternary expression always evaluating to true

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 8, 2013, 21:01 UTC
Message-ID: <alpine.DEB.1.00.1308082257580.24252@s15462909.onlinehome-server.info>
In-Reply-To: <1375988103-29947-1-git-send-email-stefanbeller@googlemail.com>

Hi Stefan,

On Thu, 8 Aug 2013, Stefan Beller wrote:

> The condition before the changed line dereferences 'one' to query the mode,
> so if the condition evaluates to true, the variable one must not be null.

To show this better, please use -U10 (or some other appropriate context option) in the future.

Show 9 quoted lines

> Therefore we do not need the ternary operator depending on one, giving
> either one->path or two->path. This always evaluates to one->path, so we
> can remove the ternary operator.
> 
> The condition and the usage of the ternary operator have been introduced
> by the same commit (752c0c24, 2009-10-19, Add the --submodule option to
> the diff option family). As that commit message refers to a GitTogether
> I'd assume that patch was crafted in a hurry, so maybe overlooking the
> need for a ternary operator there.

If this is my code, I do not need a GitTogether to excuse my sloppiness. In this particular case, I imagine the appropriate fix is to test for one->path instead of removing the conditional, though.

Ciao, Johannes