Re: [PATCH/RFC 4/5] mingw: reuse tty-version of git_terminal_prompt

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 30, 2012, 18:05 UTC
Message-ID: <alpine.DEB.1.00.1211301901120.31987@s15462909.onlinehome-server.info>
In-Reply-To: <1352815447-8824-5-git-send-email-kusmabite@gmail.com>

Hi kusma,

On Tue, 13 Nov 2012, Erik Faye-Lund wrote:

Show 6 quoted lines

> The getpass-implementation we use on Windows isn't at all ideal;
> it works in raw-mode (as opposed to cooked mode), and as a result
> does not deal correcly with deletion, arrow-keys etc.
> 
> Instead, use cooked mode to read a line at the time, allowing the
> C run-time to process the input properly.

Awesome!

The patch itself has a couple Windows-specific things in compat/terminal.c that I would have loved to see in compat/mingw.c instead, but it looks as if we have no choice: restore_term() and disable_echo() need to be substantially different enough from the implementation in compat/mingw.c.

(Read: I am fine with this patch.)

Ciao, Dscho

-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en