Re: [PATCH 2/4] format-patch: use a string_list for headers
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 7, 2010, 22:13 UTC
- Message-ID
- <alpine.DEB.1.00.1003072313130.7596@pacific.mpi-cbg.de>
- In-Reply-To
- <40aa078e1003071344h5ef4358aif7888afdad1b4fc6@mail.gmail.com>
Hi,
On Sun, 7 Mar 2010, Erik Faye-Lund wrote:
Show 9 quoted lines
> On Sun, Mar 7, 2010 at 10:33 PM, Stephen Boyd <bebarino@gmail.com> wrote:
> > +static struct string_list extra_hdr = { .strdup_strings = 1 };
> > +static struct string_list extra_to = { .strdup_strings = 1 };
> > +static struct string_list extra_cc = { .strdup_strings = 1 };
> >
>
> Do we really use this C99 feature (designated initializers)? I think
> it will break MSVC builds, at least... Perhaps some other non-gcc
> platforms as well?http://repo.or.cz/w/git.git/blob?f=Documentation/SubmittingPatches#l84
Ciao, Dscho