Re: [PATCH] Wrap RUNTIME_PREFIX warning in a compile-time condition
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 23, 2010, 09:42 UTC
- Message-ID
- <alpine.DEB.1.00.1002231041230.20986@pacific.mpi-cbg.de>
- In-Reply-To
- <4B839282.1020605@viscovery.net>
Hi,
On Tue, 23 Feb 2010, Johannes Sixt wrote:
Show 16 quoted lines
> From: Johannes Sixt <j6t@kdbg.org> > > When RUNTIME_PREFIX is enabled, the installation prefix is derived by > trying a limited set of known locations where the git executable can > reside. If none of these is found, a warning is emitted. > > When git is built in a directory that matches neither of these known names, > the warning would always be emitted when the uninstalled executable is run. > This is a problem on Windows, where gitk picks the uninstalled git when > invoked on the build directory and gets confused by the warning. > > With this patch, individual developers can disable the warning by setting > > BASIC_CFLAGS += -DNO_WARN_RUNTIME_PREFIX > > in config.mak.
Would this option not prefer to be a runtime option? An environment variable should suffice.
Ciao, Dscho