Re: [PATCH] git status: do not require write permission

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 20, 2010, 01:23 UTC
Message-ID: <alpine.DEB.1.00.1001200220570.4985@pacific.mpi-cbg.de>
In-Reply-To: <7vhbqh7gpa.fsf@alter.siamese.dyndns.org>

Hi,

On Tue, 19 Jan 2010, Junio C Hamano wrote:

Show 17 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > On Wed, Jan 20, 2010 at 01:06:17AM +0100, Johannes Schindelin wrote:
> >
> >> Today, git status played violin on my nerves for the very last time.
> >> There is no good reason, really none, for git status to require
> >> write permissions.  If the index is not up-to-date, so be it, I
> >> cannot commit anyway.
> >
> > I agree it is annoying, but this patch does not apply (and is no longer
> > needed) on master since the status-is-no-longer-commit-dry-run series
> > has been merged.
> >
> > I don't know if it is worth putting your fix onto maint.
> 
> I think the patch itself makes sense, even though the log message seems to
> be with more noise and frustrationthan with useful information.

If you think so.

> And "for the very last time" is probably a good characterization, as
> status will no longer be "commit --dry-run" in the coming release ;-)

This comment was because I was fully prepared to do the same as with so many patches: keep them in my personal repository until time finally tells that that patch should go into 'next'.

And as you realized, I managed to forget a commit --amend, which would have replaced 1 with !is_status.

BTW you can tell me directly that you do not want any patches from me anymore, rather than dancing around the issue. I kind of figured that already anyway.

Ciao, Dscho