Re: [msysGit] [PATCH] Installer: Create builtins as symbolic links on Vista
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 16, 2010, 00:41 UTC
- Message-ID
- <alpine.DEB.1.00.1001160139070.4985@pacific.mpi-cbg.de>
- In-Reply-To
- <1263593219-6032-1-git-send-email-michael.lukashov@gmail.com>
Hi,
On Fri, 15 Jan 2010, Michael Lukashov wrote:
Show 6 quoted lines
> When create builtins, first try to use CreateSymbolicLinkW function. If > symbolic link creating fails, hard links are created. > > Tested under WinXP (both FAT32 and NTFS), Vista and Win7. > > This patch applies on top of ss/installer-improvements branch.
The commit message is a wonderful place to convince readers that the patched code has a tremendous advantage over the existing code.
Maybe you forgot to add this discussion?
Ciao, Dscho
P.S.: I am quite sure that the Git mailing list is maybe better suited for patches to the Git source code rather than for patches to the InnoSetup code of Git for Windows.