git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff --color-words -U0: fix the location of hunk headers

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Oct 31, 2009, 11:48 UTC
Message-ID
<alpine.DEB.1.00.0910311247590.4985@pacific.mpi-cbg.de>
In-Reply-To
<7vr5sklo7c.fsf@alter.siamese.dyndns.org>
Hi,
On Fri, 30 Oct 2009, Junio C Hamano wrote:
Show 7 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > The reason I did not do that was to avoid a full subroutine call, as I 
> > expected this code path to be very expensive.
> 
> This is only done for the "word diff" mode, and my gut feeling is that it
> is not such a big issue.

Yeah, sorry, I should have stated explicitely that I no longer think that there is a performance issue.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 12 of 14 in “fix "git diff --color-words -U0"”
  1. 0/3 fix "git diff --color-words -U0"Markus Heidelberg, Oct 28, 2009
  2. 1/3 t4034-diff-words: add a test for word diff without contextMarkus Heidelberg, Oct 28, 2009
  3. 2/3 diff: move the handling of the hunk header after the changed linesMarkus Heidelberg, Oct 28, 2009
  4. 3/3 diff: fix the location of hunk headers for "git diff --color-words -U0"Markus Heidelberg, Oct 28, 2009
  5. diff --color-words -U0: fix the location of hunk headersJohannes Schindelin, Oct 29, 2009
  6. Markus HeidelbergOct 29, 2009
  7. Johannes SchindelinOct 29, 2009
  8. Markus HeidelbergOct 29, 2009
  9. Junio C HamanoOct 30, 2009
  10. Johannes SchindelinOct 30, 2009
  11. Junio C HamanoOct 30, 2009
  12. Johannes SchindelinOct 31, 2009
  13. Junio C HamanoOct 28, 2009
  14. Markus HeidelbergOct 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.