Re: [PATCH] Fix memory leak in transport-helper
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 27, 2009, 14:11 UTC
- Message-ID
- <alpine.DEB.1.00.0910271510430.4985@pacific.mpi-cbg.de>
- In-Reply-To
- <alpine.LNX.2.00.0910270032170.14365@iabervon.org>
Hi,
On Tue, 27 Oct 2009, Daniel Barkalow wrote:
Show 14 quoted lines
> diff --git a/transport-helper.c b/transport-helper.c
> index f57e84c..479539d 100644
> --- a/transport-helper.c
> +++ b/transport-helper.c
> @@ -67,6 +67,13 @@ static int disconnect_helper(struct transport *transport)
> return 0;
> }
>
> +static int close_helper(struct transport *transport)
> +{
> + disconnect_helper(transport);
> + free(transport->data);
> + return 0;
> +}Why did you not leech the transport->data = NULL; part from Peff/Sverre's patch?
Ciao, Dscho