Re: [PATCH] Add the utterly important 'mispel' command

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 4, 2009, 10:52 UTC
Message-ID: <alpine.DEB.1.00.0910041250420.4985@pacific.mpi-cbg.de>
In-Reply-To: <20091004065239.GA7890@coredump.intra.peff.net>

Hi,

On Sun, 4 Oct 2009, Jeff King wrote:

Show 15 quoted lines

> On Sun, Oct 04, 2009 at 12:41:55AM +0200, Johannes Schindelin wrote:
> 
> > --- a/builtin.h
> > +++ b/builtin.h
> > @@ -12,6 +12,7 @@ extern const char git_more_info_string[];
> >  
> >  extern void list_common_cmds_help(void);
> >  extern const char *help_unknown_cmd(const char *cmd);
> > +const char *help_mispeld_comd(const char *cmd);
> >  extern void prune_packed_objects(int);
> >  extern int read_line_with_nul(char *buf, int size, FILE *file);
> >  extern int fmt_merge_msg(int merge_summary, struct strbuf *in,
> 
> Hmph. This hunk doesn't apply to Shawn's master, and your blob sha1 is
> not in my repository for a 3-way merge. ;P

Hmm.  It might be based on 4msysgit.git's 'devel' branch.

Show 8 quoted lines

> Also, I think there is a bug:
> 
>   $ git mispel show-branc
>   error: You probably meant show-index
> 
> Or is it intentional for it to throw the user off track?
> 
> Let this be a lesson, kids: don't drink and code.

Well, the command is called "mispel", not "autocorrect". So I think you misunderstood the purpose of the patch.

Let this be a lesson, kids: don't review GitTogether patches before you had a drink.

Ciao, Dscho