Re: [PATCH 4/8] Allow fetch to modify refs

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 4, 2009, 10:46 UTC
Message-ID: <alpine.DEB.1.00.0909041243420.4605@intel-tinevez-2-302>
In-Reply-To: <alpine.LNX.2.00.0909032213260.28290@iabervon.org>

Hi,

On Thu, 3 Sep 2009, Daniel Barkalow wrote:

> +	/**
> +	 * Fetch the objects for the given refs. Note that this gets
> +	 * an array, and should ignore the list structure.

This is not clear at all. You should rather say "[...] and should not look at, or set, the 'next' member of the refs".

> +	 *
> +	 * If the transport did not get hashes for refs in
> +	 * get_refs_list(), it should set the old_sha1 fields in the
> +	 * provided refs now.

Not the "new_sha1"?

Show 5 quoted lines

> +	 **/
> +	int (*fetch)(struct transport *transport, int refs_nr, struct ref **refs);
> +
> [...]
> +	/** get_refs_list(), fetch(), and push_refs() can keep

The "/**" wants to have a line to itself.

Show 6 quoted lines

> +	 * resources (such as a connection) reserved for futher
> +	 * use. disconnect() releases these resources.
> +	 **/
>  	int (*disconnect)(struct transport *connection);
>  	char *pack_lockfile;
>  	signed verbose : 2;

Ciao, Dscho