git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4 08/12] Teach the notes lookup code to parse notes trees with various fanout schemes

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 28, 2009, 08:48 UTC
Message-ID
<alpine.DEB.1.00.0908281046560.7434@intel-tinevez-2-302>
In-Reply-To
<7vprahq8iv.fsf@alter.siamese.dyndns.org>
Hi,
On Thu, 27 Aug 2009, Junio C Hamano wrote:
Show 21 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > I half-agree, the code should decide which fanout scheme to use, but 
> > _only_ when producing new notes.
> >
> > I imagine that it could merge the existing notes, and try to make sure 
> > that there are no more blobs in a given subtree than a certain 
> > threshold; if that threshold is reached, it could fan-out using 
> > 2-digit subtrees, merging what needs merging (by concatenation) along 
> > the way.
> >
> > The natural precedence of shallower paths/longer basenames should cope 
> > well with that (i.e. prefer to show abcd/... over ab/cd/...).
> 
> Oh, if the plan for merging the trees is such that it takes care of 
> "multiple notes pointing at the same commit" issues like you outline, 
> then I can see it would work nicely.
> 
> At that point, fan-out would become merely an implementation detail, 
> something the end user never needs to worry about, just like what base 
> object is chosen to represent another object in a packfile.

Oh, that's where you're coming from! Now I understand your concerns; it never occurred to me that the user should be encouraged to add notes to the tree herself. I was always under the impression that the fan-out is an implementation detail best hidden from the user.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 14 of 38 in “[PATCHv4 00/12] git notes”
  1. Johan HerlandAug 27, 2009
  2. 01/12 Introduce commit notesJohan Herland, Aug 27, 2009
  3. 02/12 Add a script to edit/inspect notesJohan Herland, Aug 27, 2009
  4. 03/12 Speed up git notes lookupJohan Herland, Aug 27, 2009
  5. 04/12 Add an expensive test for git-notesJohan Herland, Aug 27, 2009
  6. 05/12 Teach "-m <msg>" and "-F <file>" to "git notes edit"Johan Herland, Aug 27, 2009
  7. 06/12 fast-import: Add support for importing commit notesJohan Herland, Aug 27, 2009
  8. 07/12 t3302-notes-index-expensive: Speed up create_repo()Johan Herland, Aug 27, 2009
  9. 08/12 Teach the notes lookup code to parse notes trees with various fanout schemesJohan Herland, Aug 27, 2009
  10. Junio C HamanoAug 27, 2009
  11. Johan HerlandAug 27, 2009
  12. Johannes SchindelinAug 27, 2009
  13. Junio C HamanoAug 27, 2009
  14. Johannes SchindelinAug 28, 2009
  15. Junio C HamanoAug 27, 2009
  16. Shawn O. PearceAug 27, 2009
  17. Junio C HamanoAug 27, 2009
  18. Johan HerlandAug 27, 2009
  19. Jeff KingAug 27, 2009
  20. Junio C HamanoAug 28, 2009
  21. Sverre RabbelierAug 28, 2009
  22. Junio C HamanoAug 28, 2009
  23. Sverre RabbelierAug 28, 2009
  24. Junio C HamanoAug 28, 2009
  25. Sverre RabbelierAug 28, 2009
  26. Junio C HamanoAug 28, 2009
  27. Johannes SchindelinAug 28, 2009
  28. Johan HerlandAug 28, 2009
  29. Johannes SchindelinAug 28, 2009
  30. Johan HerlandAug 28, 2009
  31. Johannes SchindelinAug 27, 2009
  32. 09/12 Selftests verifying semantics when loading notes trees with various fanoutsJohan Herland, Aug 27, 2009
  33. 10/12 notes.c: Implement simple memory pooling of leaf nodesJohan Herland, Aug 27, 2009
  34. Alex RiesenAug 27, 2009
  35. Johan HerlandAug 27, 2009
  36. Johan HerlandAug 27, 2009
  37. 11/12 Add flags to get_commit_notes() to control the format of the note stringJohan Herland, Aug 27, 2009
  38. 12/12 Add '%N'-format for pretty-printing commit notesJohan Herland, Aug 27, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.