Re: [PATCH 06/11] Add miss git-compat-util.h at regex.c and fnmatch.c Add git-compat-util.h to enable build at MSVC environment

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 17, 2009, 16:51 UTC
Message-ID: <alpine.DEB.1.00.0908171850370.4991@intel-tinevez-2-302>
In-Reply-To: <1250525103-5184-1-git-send-email-lznuaa@gmail.com>

Hi,

On Tue, 18 Aug 2009, Frank Li wrote:

> Signed-off-by: Frank Li <lznuaa@gmail.com>

How about this instead?

	Add missing git-compat-util.h to regex.c and fnmatch.c

	This will be needed to compile with Microsoft Visual C++.

Show 12 quoted lines

> diff --git a/compat/fnmatch/fnmatch.c b/compat/fnmatch/fnmatch.c
> index 14feac7..5cbd49c 100644
> --- a/compat/fnmatch/fnmatch.c
> +++ b/compat/fnmatch/fnmatch.c
> @@ -16,6 +16,10 @@
>     write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
>     Boston, MA 02111-1307, USA.  */
>  
> +#ifdef _MSC_VER
> +#include "git-compat-util.h"
> +#endif
> +

Why not leave those #ifdef guards? Either they don't hurt, or they will hurt Microsoft Visual C++, too.

Ciao, Dscho