Re: Using VC build git (new patch)

Hi,

On Sun, 16 Aug 2009, Frank Li wrote:

A single monster patch?

Hmm.

Please understand that I will not review that unless it is split up into nice little and reviewable chunks.

This diffstat does not let me expect well-defined changes, either, sorry:

 builtin-fast-export.c               |    1 +
 compat/fnmatch/fnmatch.c            |    2 +
 compat/mingw.c                      |   68 ++-
 compat/mingw.h                      |   21 +-
 compat/regex/regex.c                |    8 +-
 compat/snprintf.c                   |    7 +-
 compat/vcbuild/.gitignore           |    3 +
 compat/vcbuild/ReadMe               |   13 +
 compat/vcbuild/git/git.vcproj       |  197 +++++
 compat/vcbuild/include/dirent.h     |  127 ++++
 compat/vcbuild/include/unistd.h     |  174 +++++
 compat/vcbuild/libgit/libgit.vcproj | 1347 +++++++++++++++++++++++++++++++++++
 compat/vcbuild/porting.c            |   13 +
 compat/vcbuild/sys/time.h           |   21 +
 compat/winansi.c                    |    8 +
 git-compat-util.h                   |    2 +-
 help.c                              |    5 +-
 pager.c                             |    4 +-
 run-command.c                       |   11 +-
 run-command.h                       |    2 +-
 setup.c                             |    2 +-
 21 files changed, 2011 insertions(+), 25 deletions(-)

It still modifies mingw.c and mingw.h, even if it has been strongly suggested to leave those alone.

It touches all kinds of files that appear to be completely unrelated to Microsoft Visual C++.

Remember: breaking things for existing users (and changing something that 
works for them quite well readily risks that) is not an option.

And the commit message does not even explain half of it...

Ciao, Dscho