Re: [PATCH 08/13] Add support for "import" helper command

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 5, 2009, 21:23 UTC
Message-ID: <alpine.DEB.1.00.0908052321580.8306@pacific.mpi-cbg.de>
In-Reply-To: <alpine.LNX.2.00.0908051708060.2147@iabervon.org>

Hi,

On Wed, 5 Aug 2009, Daniel Barkalow wrote:

Show 19 quoted lines

> On Wed, 5 Aug 2009, Johannes Schindelin wrote:
> 
> > Hi,
> > 
> > On Wed, 5 Aug 2009, Daniel Barkalow wrote:
> > 
> > > This command, supported if the "import" capability is advertized,
> > > allows a helper to support fetching by outputting a git-fast-import
> > > stream.
> > 
> >   If both the "import" and the "fetch" capability are advertised, the 
> >   "import" capability is ignored.
> 
> The transport code notices that both are supported; it just doesn't use 
> the less convenient one. It would be wrong for helpers to advertize both 
> and depend on only "fetch" being used. (For example, there's no reason 
> that hg couldn't use one of these helpers and use the "import" capability 
> despite the "fetch" capability also being advertized, because "import" 
> produces results which are portable across local vcses.)

My point was not to criticize the decision. My point was to criticize the absence of the comment from both commit message and documentation.

Ciao, Dscho