Re: [PATCH 1/3] log: Show reflog date with --date=normal

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 28, 2009, 13:27 UTC
Message-ID: <alpine.DEB.1.00.0907281524220.8306@pacific.mpi-cbg.de>
In-Reply-To: <200907281511.10010.trast@student.ethz.ch>

Hi,

On Tue, 28 Jul 2009, Thomas Rast wrote:

Show 8 quoted lines

> Johannes Schindelin wrote:
> > 
> > Inspecting reflogs is an interactive task, and I do not think that 
> > this justifies the complications you suggested.  I can _easily_ say 
> > "git log -g" and then "git show --date=relative <commit>".  Not that I 
> > _ever_ needed such a thing.
> 
> That's something entirely different.

No, it's not. The '--date=<format>' option was always about the commit dates. It was just DWIMed in the context of '--reflog' to mean "show me the dates in the reflogs, too".

As such, I think having '--no-date' switch that DWIM off (and reverting to default date format for the commit dates) is perfectly acceptable and consistent.

Having DATE_NORMAL and DATE_DEFAULT do exactly the same thing -- except in the presence of '--reflog' -- is nothing I want to see in Git. It is inconsistent, unintuitive and confusing.

I could live with switching off the DWIMery and introducing '--reflog-date=<format', though but the whole point of our IRC discussion was to make it less painful to switch on the date-based reflogs, no?

Now, it often happened that Junio just ignored such comments of mine, and I had to live with the consequences. I just hope it does not happen here.

Ciao, Dscho