git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] git repack: keep commits hidden by a graft

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 24, 2009, 09:36 UTC
Message-ID
<alpine.DEB.1.00.0907241133080.19988@intel-tinevez-2-302>
In-Reply-To
<7veis6vfh5.fsf@alter.siamese.dyndns.org>
Hi,
On Thu, 23 Jul 2009, Junio C Hamano wrote:
> It would probably make more sense to call it "--keep-real-parents" or 
> something.
Much better.
> Do we want to cull duplicated parents?  I do not think it matters in 
> this particular context of checking the reachability, but I am just 
> double checking if you thought about the issue.

I thought about it, and decided it is not worth the hassle: originally I had the option in setup_revisions() until I realized that this is never called by pack-objects. So how about this addition to the commit message:

	As this behavior can only be triggered by git pack-objects, and as 
	that command handles duplicate parents gracefully, we do not 
	bother to cull such parents.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 10 in “Make git-gc more robust with regard to grafts”
  1. 0/2 Make git-gc more robust with regard to graftsJohannes Schindelin, Jul 23, 2009
  2. 1/2 Add a test showing that 'git repack' throws away grafted-away parentsJohannes Schindelin, Jul 23, 2009
  3. Björn SteinbrinkJul 23, 2009
  4. 2/2 git repack: keep commits hidden by a graftJohannes Schindelin, Jul 23, 2009
  5. Junio C HamanoJul 24, 2009
  6. Johannes SchindelinJul 24, 2009
  7. Junio C HamanoJul 24, 2009
  8. Björn SteinbrinkJul 24, 2009
  9. Johannes SchindelinJul 24, 2009
  10. Junio C HamanoJul 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.