Re: [PATCH v2 0/1] Fix rebase -p --onto
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 22, 2009, 18:05 UTC
- Message-ID
- <alpine.DEB.1.00.0907222004370.7343@intel-tinevez-2-302>
- In-Reply-To
- <20090722173635.GN7878@vinegar-pot.mit.edu>
Hi,
On Wed, 22 Jul 2009, Greg Price wrote:
Show 16 quoted lines
> On Wed, Jul 22, 2009 at 07:07:17PM +0200, Johannes Schindelin wrote: > > On Wed, 22 Jul 2009, Greg Price wrote: > > > [...] when the great day comes that rebase -i -p can reorder commits > > > > If you want to help, I would be so thankful. In that case, it might make > > more sense to hold off this patch and integrate it into the rebase-i-p > > patch series, rather than requiring a rebase of rebase-i-p on top of your > > patches, which will postpone said day only further. > > Where is your patch series and what are the big things that need doing > before it can be merged? I can't promise a great deal of time up > front, but I would be glad to look at it and may be able to pitch in. > > Because this patch is about --onto together with -p and doesn't really > involve -i, I think it still makes sense to merge. It's only one line > plus tests, so I don't think it will create that much of a rebase burden.
Fair enough. I was fooled by the size of the mail; the main part is the test (which is good), though, so strike my objections.
Ciao, Dscho