git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] prune-packed: migrate to parse-options

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 9, 2009, 10:51 UTC
Message-ID
<alpine.DEB.1.00.0907091250120.4339@intel-tinevez-2-302>
In-Reply-To
<1247030141-11695-5-git-send-email-bebarino@gmail.com>
Hi,
I reviewed all four patches, and like them.  Just a minor nit:
On Tue, 7 Jul 2009, Stephen Boyd wrote:
> Add --dry-run and --quiet to be more consistent with the rest of git.

You should say here that you add the _long_ options (the short options were supported already); I almost expected you to sneak in additional features with the parseoptification.

Same goes for 3/4, I guess.

Thanks, Dscho

Previous: Stephen BoydNext: Stephen Boyd
Message 6 of 9 in “Migrate simple builtins to parse-options”
  1. 0/4 Migrate simple builtins to parse-optionsStephen Boyd, Jul 8, 2009
  2. 1/4 write-tree: migrate to parse-optionsStephen Boyd, Jul 8, 2009
  3. 2/4 tag-verify: migrate to parse-optionsStephen Boyd, Jul 8, 2009
  4. 3/4 verify-pack: migrate to parse-optionsStephen Boyd, Jul 8, 2009
  5. 4/4 prune-packed: migrate to parse-optionsStephen Boyd, Jul 8, 2009
  6. Johannes SchindelinJul 9, 2009
  7. Stephen BoydJul 9, 2009
  8. Stephen BoydJul 9, 2009
  9. Stephen BoydJul 9, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.