Re: [PATCH v3 2/2] rebase -i: save only original commit sha1 to save author information

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 22, 2009, 09:27 UTC
Message-ID: <alpine.DEB.1.00.0906221126040.4168@intel-tinevez-2-302>
In-Reply-To: <200906220935.11581.jnareb@gmail.com>

Hi,

On Mon, 22 Jun 2009, Jakub Narebski wrote:

Show 9 quoted lines

> Christian Couder wrote:
> 
> > +                       GIT_AUTHOR_NAME="$author_ident_name" \
> > +                       GIT_AUTHOR_EMAIL="$author_ident_email" \
> > +                       GIT_AUTHOR_DATE="$author_ident_date" \
> >                         $USE_OUTPUT git commit --no-verify \
> >                                 $MSG_OPT "$EDIT_OR_FILE" || failed=t
> 
> Why not use 'git commit -C $(cat "$SAVED_COMMIT") ...' ?

Unfortunately, the quoted part lacks context, so I can only guess that the issue is "squash". You need to retain authorship, but want to present a message to the user that is in no commit yet. And no, constructing a new commit for the purpose of passing it to "commit -C" would be way too shabby coding IMO.

Ciao, Dscho