Re: [PATCH 2/3] pull --rebase: Add support for rebased default upstream

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 5, 2009, 23:22 UTC
Message-ID: <alpine.DEB.1.00.0906060120140.26154@pacific.mpi-cbg.de>
In-Reply-To: <1244231617-17754-2-git-send-email-santi@agolina.net>

Hi,

On Fri, 5 Jun 2009, Santi Béjar wrote:

Show 5 quoted lines

> Also add a test to check for this case and another one (failing) to
> test rebasing two branches on top of a rebased upstream using just
> 'git pull --rebase'.
> 
> Signed-off-by: Santi Béjar <santi@agolina.net>

Either I am a stupid moron (which is a completely valid suggestion) or this commit message lacks in detail severely.

For example, when I "git pull --rebase junio next" and "next" was rebased, it works _perfectly_, so I do not see any need for a fix.

Further, this:

> ---
>  git-parse-remote.sh |    8 +++++++-
>  t/t5520-pull.sh     |   29 +++++++++++++++++++++++++++++
>  2 files changed, 36 insertions(+), 1 deletions(-)

... suggests to me that pull --rebase is not even affected by your patch. So maybe you want to clarify so much that even stupid morons understand what you want to achieve, and how.

Ciao, Dscho