Re: [PATCH v2] daemon.c: fix segfault on OS X
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 27, 2009, 15:53 UTC
- Message-ID
- <alpine.DEB.1.00.0904271753190.7741@intel-tinevez-2-302>
- In-Reply-To
- <49F5BA55.3060606@googlemail.com>
Hi,
On Mon, 27 Apr 2009, Benjamin Kramer wrote:
Show 12 quoted lines
> On OS X (and maybe other unices), getaddrinfo(3) returns NULL > in the ai_canonname field if it's called with an IP address for > the hostname. We'll now use the IP address for the hostname if > ai_canonname was NULL, this also matches the behaviour on Linux. > > steps to reproduce: > $ git daemon --export-all > $ git clone git://127.0.0.1/frotz > => git daemon's fork (silently) segfaults. > > Remove the pointless loop while at it. There is only one iteration > because of the break; on the last line and there are no continues.
Thanks, I indeed overlooked the "break;", Dscho