git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RESEND] git-submodule: add support for --rebase.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 21, 2009, 08:47 UTC
Message-ID
<alpine.DEB.1.00.0904211047311.10279@pacific.mpi-cbg.de>
In-Reply-To
<20090421074540.GA7885@dingo.redhat.com>
Hi,
On Tue, 21 Apr 2009, Peter Hutterer wrote:
Show 11 quoted lines
> On Mon, Apr 20, 2009 at 11:55:54AM +0200, Johannes Schindelin wrote:
> > On Mon, 20 Apr 2009, Peter Hutterer wrote:
> > 
> > > 'git submodule update --rebase' rebases your local branch on top of what would
> > 
> > This line is so long that it got wrapped in my mail program.  But it is 
> > even worse: we would like to show this in an 80-column display with a 
> > 4-space indent, so it would be nice if you could rewrap to 76 columns (I 
> > even use 72 columns, because it looks nicer).
> 
> amended to 72 cols, see below.
Thanks.
Show 19 quoted lines
> > > I'm still unsure about whether to change the wording (it currently uses 
> > > the same terms as git-rebase and the rest of the git-submodule man 
> > > page). Please let me know what to do to get this patch done.
> > 
> > AFAIR I gave an alternative wording, am I wrong?
> 
> yes, but tbh. I found it a bit confusing. Your suggestion was
> 
>        "Instead of detaching the HEAD to the revision committed in the
>         superproject, rebase the current branch onto that revision."
> 
> How about this one, basically the same but split up in two sentences:
> 
> +--rebase::
> +	This option is only valid for the update command.
> +	Rebase the current branch onto the commit recorded in the
> +	superproject. If this option is given, the submodule's HEAD will not
> +	be detached. If a a merge failure prevents this process, you will have
> +	to resolve these failures with linkgit:git-rebase[1].
Way better!

Thank you, Dscho

Previous: Peter HuttererNext: Peter Hutterer
Message 4 of 9 in “git-submodule: add support for --rebase.”
  1. git-submodule: add support for --rebase.Peter Hutterer, Apr 19, 2009
  2. Johannes SchindelinApr 20, 2009
  3. Peter HuttererApr 21, 2009
  4. Johannes SchindelinApr 21, 2009
  5. Peter HuttererApr 23, 2009
  6. Johannes SchindelinApr 23, 2009
  7. Peter HuttererApr 23, 2009
  8. Johannes SchindelinApr 24, 2009
  9. Junio C HamanoApr 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.