Re: [PATCH] Add an option for using any HTTP authentication scheme, not only basic

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 14, 2009, 21:08 UTC
Message-ID: <alpine.DEB.1.00.0904142307110.10279@pacific.mpi-cbg.de>
In-Reply-To: <Pine.LNX.4.64.0904142350140.7479@localhost.localdomain>

Hi,

On Tue, 14 Apr 2009, Martin Storsjö wrote:

Show 11 quoted lines

> diff --git a/http.c b/http.c
> index 2e3d649..0b18c64 100644
> --- a/http.c
> +++ b/http.c
> @@ -26,6 +26,9 @@ static long curl_low_speed_time = -1;
>  static int curl_ftp_no_epsv;
>  static const char *curl_http_proxy;
>  static char *user_name, *user_pass;
> +#if LIBCURL_VERSION_NUM >= 0x070a06
> +static int curl_http_auth_any = 0;
> +#endif

In six months from now, it might be easier to read

#if LIBCURL_VERSION_NUM >= 0x070a06 #define LIBCURL_CAN_HANDLE_ANY_AUTH #endif

[...]

#ifdef LIBCURL_CAN_HANDLE_ANY_AUTH [...]

Don't you agree?

Thanks, Dscho