Re: [PATCH] Fix 'git checkout <submodule>' to update the index

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 2, 2009, 20:27 UTC
Message-ID: <alpine.DEB.1.00.0904022227400.7464@intel-tinevez-2-302>
In-Reply-To: <7vprfuesra.fsf@gitster.siamese.dyndns.org>

Hi,

On Thu, 2 Apr 2009, Junio C Hamano wrote:

Show 24 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > While 'git checkout <submodule>' should not update the submodule's
> > working directory, it should update the index.  This is in line with
> > how submodules are handled in the rest of Git.
> >
> > While at it, test 'git reset [<commit>] <submodule>', too.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >
> > 	I have no idea who thought that it would be a good idea to leave 
> > 	the submodules alone, but I think it is highly counterintuitive 
> > 	that
> >
> > 		git checkout <submodule>
> >
> > 	does not touch the index.
> 
> I do not see anything that treats submodule specially in the scripted 
> version and this check for S_ISGITLINK() has been there since the very 
> beginning of C rewrite 782c2d6 (Build in checkout, 2008-02-07), so it is 
> a regression fix that can go to maint (all the way down to 1.5.5 if you 
> want).

I would appreciate that.

Thanks, Dscho