Re: [RFC/PATCH] graph API: Added logic for colored edges.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 31, 2009, 10:21 UTC
Message-ID: <alpine.DEB.1.00.0903311213260.10279@pacific.mpi-cbg.de>
In-Reply-To: <20090330141322.GA6221@linux.vnet>

Hi,

On Mon, 30 Mar 2009, Allan Caffee wrote:

Show 13 quoted lines

> @@ -445,6 +492,12 @@ static void graph_update_columns(struct git_graph *graph)
>  			for (parent = first_interesting_parent(graph);
>  			     parent;
>  			     parent = next_interesting_parent(graph, parent)) {
> +				/*
> +				 * If this is a merge increment the current
> +				 * color.
> +				 */
> +				if (graph->num_parents > 1)
> +					get_next_column_color(graph);
>  				graph_insert_into_new_columns(graph,
>  							      parent->item,
>  							      &mapping_idx);

Hmm. I would have expected the color to be an argument to graph_insert_into_new_columns()...

Oh, and please forget about my stupid babbling about using struct decoration for colors: the column already knows commit and color, so if you need the color in a functino in addition to the commit, you should pass either the column struct instead, or the commit and the color as individual parameters.

This concludes my review ;-)

Thanks, Dscho