Re: [PATCH 01/10] refs: add "for_each_bisect_ref" function

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 26, 2009, 16:52 UTC
Message-ID: <alpine.DEB.1.00.0903261748280.12753@intel-tinevez-2-302>
In-Reply-To: <49CBA42D.3000404@drmicha.warpmail.net>

Hi,

On Thu, 26 Mar 2009, Michael J Gruber wrote:

Show 13 quoted lines

> Christian Couder venit, vidit, dixit 26.03.2009 08:48:
> 
> > Le jeudi 26 mars 2009, Sverre Rabbelier a écrit :
> >
> >> A 10 patches series with no cover letter?
> > 
> > I am not a big fan of cover letters. Usually I prefer adding comments 
> > in the patches.
> 
> I'm sorry I have to say that, but your individual preferences don't 
> matter. Many of us would do things differently, each in their own way, 
> but people adjust to the list's preferences. It's a matter of attitude. 
> So, please...

Actually, a better way to ask for a cover letter would have been to convince Christian. So I'll try that.

>From the patch series' titles (especially when they are cropped due to the

text window being too small to fit the indented thread), it is not all that obvious what you want to achieve with those 10 patches.

>From recent discussions, I seem to remember that you wanted to have some

cute way to mark commits as non-testable during a bisect, and I further seem to remember that Junio said that very method should be usable outside of bisect, too.

Unfortunately, that does not reveal to me, quickly, what is the current state of affairs, and what you changed since the last time.

In addition, I am very sorry that I cannot review your patches; day job is killing me right now.

Ciao, Dscho