Re: [PATCH] git-cget: prints elements of C code in the git repository

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 24, 2009, 13:52 UTC
Message-ID: <alpine.DEB.1.00.0903241449200.7493@intel-tinevez-2-302>
In-Reply-To: <49C8E074.4030808@gmail.com>

Hi,

On Tue, 24 Mar 2009, Roel Kluin wrote:

> > - the name is not expressive enough,
> 
> How about get-def? If it's too long it will become tiresome to type.

IMHO "git grep-c" would be more to the point...

Show 5 quoted lines

> > - the commit message is severely lacking (I had to apply it and run it 
> >   to find out what problem it tries to solve),
> 
> This is probably better:
> [...]

Yes, I like it!

Show 5 quoted lines

> > - maybe it would be nicer to integrate this into git grep itself?  
> >   Maybe by allowing multi-line matches and default patterns, or 
> >   pattern templates?
> 
> I did attempt to program it in C, but I am more comfortable with bash.

Did I misunderstand your code? I thought all it does is provide a way to match multiline patterns... but then, I could not do more than just quickly glance over the code.

> Also, what would be more appropriate for this purpose, I think, is a git 
> sed.

Just as it happens, this is a toy I am working on and off these days... strbuf_regsub() is already done, and half the needed code is in my version git grep.

Ciao, Dscho