Re: [PATCH 2/2] MinGW: a hardlink implementation
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 17, 2009, 10:12 UTC
- Message-ID
- <alpine.DEB.1.00.0903171110420.6393@intel-tinevez-2-302>
- In-Reply-To
- <49BF5563.2060500@kdbg.org>
Hi,
On Tue, 17 Mar 2009, Johannes Sixt wrote:
Show 9 quoted lines
> From: Petr Kodl <petrkodl@gmail.com> > Date: Sat, 24 Jan 2009 15:04:39 +0100 > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > Signed-off-by: Johannes Sixt <j6t@kdbg.org> > --- > This is the meat of Petr's original patch with the fixup that was > discussed in the msysgit mailing list (WINAPI was added in the > typedef).
To save everybody searching why WINAPI is needed: in the error case (e.g. when you try to hard link from a different device), the stack was corrupted, leading to a rather nasty segmentation fault (which has a different name on Windows, just as everything else: access violation):
http://code.google.com/p/msysgit/issues/detail?id=204
Ciao, Dscho