Re: [PATCH 1/2] Use a common function to get the pretty name of refs
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 9, 2009, 16:11 UTC
- Message-ID
- <alpine.DEB.1.00.0903091710020.6358@intel-tinevez-2-302>
- In-Reply-To
- <alpine.LNX.1.00.0903091159000.19665@iabervon.org>
Hi,
On Mon, 9 Mar 2009, Daniel Barkalow wrote:
Show 13 quoted lines
> On Mon, 9 Mar 2009, Johannes Schindelin wrote: > > > On Sun, 8 Mar 2009, Daniel Barkalow wrote: > > > > > The result should be consistent between fetch and push, so we ought > > > to use the same code in both cases, even though it's short. > > > > You might want to mention that we cannot use skip_prefix() here, as > > that function does not give us any clue if something was skipped at > > all, and we must _not_ skip multiple prefixes. > > I didn't even know about the skip_prefix() function; I just moved code > around.
But I know the function. And I had to look at the code to end the head-scratching. Therefore I'd like the paragraph I wrote to be part of the commit message, to save other people from going bald.
Ciao, Dscho