Re: [PATCH] clone: ignore --depth when cloning locally (implicitly --local)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 26, 2009, 22:55 UTC
Message-ID: <alpine.DEB.1.00.0902262352380.10279@pacific.mpi-cbg.de>
In-Reply-To: <7v8wnsrf55.fsf@gitster.siamese.dyndns.org>

Hi,

On Thu, 26 Feb 2009, Junio C Hamano wrote:

Show 16 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > When cloning locally, we default to --local, as it makes the whole
> > operation fast and efficient.
> >
> > As the most common intent of cloning with a --depth parameter is to
> > save space, and --local saves space more than --depth ever can,
> > warn the user and ignore the --depth parameter when cloning locally.
> >
> > Should --depth be desired, the user can always force proper cloning
> > by using a file:// URL.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> Makes sense.  I'm inclined to apply this as a "fix" before 1.6.2, but I
> cannot exactly say what we are fixing.  User's expectations?

It seems somebody mentioned on IRC that --depth with --no-local will not work as expected, but was not willing to write to the list, or for that matter, do anything else.

So given that level of enthusiasm for _supporting_ this feature, I am inclined to postpone the patch, or drop it altogether.

I mean, I tried to be a good netizen and not let a patch I started go stale, but it is not my itch, and if those whose itch it is do not care, maybe I shouldn't, either.

Ciao, Dscho