Re: [PATCH 4/6] Improve error message for git-filter-branch

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 19, 2009, 15:03 UTC
Message-ID: <alpine.DEB.1.00.0902191602520.6223@intel-tinevez-2-302>
In-Reply-To: <43d8ce650902190619u149b4619k3f9e08bc1e5869f8@mail.gmail.com>

Hi,

On Thu, 19 Feb 2009, John Tapsell wrote:

Show 7 quoted lines

> 2009/2/19 John Tapsell <johnflux@gmail.com>:
> > Tell the user that a backup (original) already exists, and how to solve
> > this problem (with -f option)
> 
> 
> "Oh, and also all are:
> Signed-off-by: John Tapsell <johnflux@gmail.com>"

Might be nice to resend it so that the maintainer has less work, no?

Also might be nice to cut the complete crap after the only piece of information in your mail:

Show 29 quoted lines

> 
> > ---
> >  git-filter-branch.sh |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/git-filter-branch.sh b/git-filter-branch.sh
> > index 27b57b8..1ca45e2 100755
> > --- a/git-filter-branch.sh
> > +++ b/git-filter-branch.sh
> > @@ -226,7 +226,8 @@ while read sha1 type name
> >  do
> >        case "$force,$name" in
> >        ,$orig_namespace*)
> > -               die "Namespace $orig_namespace not empty"
> > +               die "Cannot backup - a previous backup already exists in $orig_namespace\n" \
> > +                   "Force overwriting the backup with -f"
> >        ;;
> >        t,$orig_namespace*)
> >                git update-ref -d "$name" $sha1
> > --
> > 1.6.2.rc1.3.g7d31b.dirty
> >
> >
> >
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>