Re: [PATCH 0/2] RUNTIME_PREFIX enhancements

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 18, 2009, 21:11 UTC
Message-ID: <alpine.DEB.1.00.0902182208070.10279@pacific.mpi-cbg.de>
In-Reply-To: <499C63C2.3050405@kdbg.org>

Hi,

On Wed, 18 Feb 2009, Johannes Sixt wrote:

Show 7 quoted lines

> Johannes Schindelin schrieb:
> > When I ran "make" in msysGit's /git/, I was greeted by a pretty unfriendly
> > message about a RUNTIME_PREFIX that could not be determined.
> 
> ;)
> 
> I have a patch in my private tree that removes the warning.

I briefly considered this. But my patch actually does something different than hiding an error condition. It copes with the very peculiar situation we have on Windows.

I still would like to see the warning if something goes wrong -- _outside_ /git/.

> This only silences the warning, but there is no guarantee that the 
> resulting git suite works because your msysgit developer may not have 
> installed stuff in C:\msysgit\libexec\git-core, yet.

The good thing: it still works. Why? Because Git actually does _not_ search the Git binaries in libexec/git-core. It adds that directory to PATH and lets the PATH lookup handle the searching. So it kind of works, but in a different manner than you think it works.

But that cannot be helped.

Ciao, Dscho