Re: [PATCH] rev-list: estimate number of bisection step left

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 17, 2009, 14:44 UTC
Message-ID: <alpine.DEB.1.00.0902171542490.6185@intel-tinevez-2-302>
In-Reply-To: <20090217060944.488184b0.chriscool@tuxfamily.org>

Hi,

On Tue, 17 Feb 2009, Christian Couder wrote:

Show 15 quoted lines

> +static int estimate_bisect_steps(int all)
> +{
> +	int log2 = 0;
> +	int left = (all >> 1) - 1;
> +
> +	if (left <= 0)
> +		return 0;
> +
> +	do {
> +		left = left >> 1;
> +		log2++;
> +	} while (left);
> +
> +	return log2;
> +}

How about this instead, calling it from cmd_rev_list directly?

	static int log2(int n)
	{
		int log2;

		for (log2 = 0; n > 1; log2++)
			n >>= 1;

		return log2;
	}

Ciao, Dscho