git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rerere: remove duplicated functions

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 14, 2009, 22:28 UTC
Message-ID
<alpine.DEB.1.00.0902142327520.10279@pacific.mpi-cbg.de>
In-Reply-To
<1234650064-639-1-git-send-email-szeder@ira.uka.de>
Hi,
On Sat, 14 Feb 2009, SZEDER Gábor wrote:
Show 8 quoted lines
> Both rerere.c and builtin-rerere.c define the static functions
> rr_path() and has_resolution() the exact same way.  To eliminate this
> code duplication this patch turns the functions in rerere.c
> non-static, and makes builtin-rerere.c use them.  Also, since this
> puts these two functions into the global namespace, rename them to
> rerere_path() and has_rerere_resolution(), respectively, and rename
> their "name" parameter to "hex", because it better reflects what that
> parameter actually is.
Thanks.  As I started that code in C, I dare say "ACK" here :-)

Ciao, Dscho

Previous: SZEDER GáborNext: Junio C Hamano
Message 4 of 5 in “rerere: remove duplicated functions”
  1. rerere: remove duplicated functionsSZEDER Gábor, Feb 14, 2009
  2. Johannes SchindelinFeb 14, 2009
  3. rerere: remove duplicated functionsSZEDER Gábor, Feb 14, 2009
  4. Johannes SchindelinFeb 14, 2009
  5. Junio C HamanoFeb 15, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.