Re: [PATCH] Allow format-patch to create patches for merges

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 26, 2009, 15:36 UTC
Message-ID: <alpine.DEB.1.00.0901261604420.25749@intel-tinevez-2-302>
In-Reply-To: <1232978650-7008-1-git-send-email-nathan.panike@gmail.com>

Hi,

On Mon, 26 Jan 2009, Nathan W. Panike wrote:

Show 5 quoted lines

> The behavior for git format-patch is to ignore merge commits, producing 
> an empty patch.  The code does not allow the user to change this 
> behavior. This patch changes that behavior by allowing the user to 
> specify -c or -m at the command line to produce a patch for a merge 
> commit.

Your patch is almost perfect, except that you

- lack an explanation when this makes sense (format-patch is commonly used 
  for mail-based patch queues, and only -m 1 would make sense there, and 
  only if you run format-patch with --first-parent),

- did not add your Sign-off :-)

Ciao, Dscho