Re: [PATCH] http-push: support full URI in handle_remote_ls_ctx()
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 18, 2009, 14:51 UTC
- Message-ID
- <alpine.DEB.1.00.0901181546100.3586@pacific.mpi-cbg.de>
- In-Reply-To
- <1232278116-6631-1-git-send-email-catap@catap.ru>
Hi,
On Sun, 18 Jan 2009, Kirill A. Korinskiy wrote:
Show 18 quoted lines
> The program calls remote_ls() to get list of files from the server > over HTTP; handle_remote_ls_ctx() is used to parse its response to > populate "struct remote_ls_ctx" that is returned from remote_ls(). > > The handle_remote_ls_ctx() function assumed that the server returns a > local path in href field, but RFC 4918 (14.7) demand of support full > URI (e.g. "http://localhost:8080/repo.git"). > > This resulted in push failure (e.g. git-http-push issues a PROPFIND > request to "/repo.git/alhost:8080/repo.git/refs/" to the server). > > Signed-off-by: Kirill A. Korinskiy <catap@catap.ru> > --- > http-push.c | 24 ++++++++++++++++++------ > 1 files changed, 18 insertions(+), 6 deletions(-) > > diff --git a/http-push.c b/http-push.c > index 7c6460919bf3eba10c46cede11ffdd9c53fd2dd2..2cb925a9ad857b6d79858d5187f14072167282e7 100644
You mean this patch is not vs junio/next(bbe7a8ed3dac72b7a1372cd92f68f47965c10100) or junio/master or junio/maint(both a4b7d08663504a57008f66a39fffe293f62c1d08) but tags/v1.6.1-rc4~13?
Ciao, Dscho